feat: add git status check before transformation #15
Conversation
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
bjohansebas
force-pushed
the
prevent-history
branch
from
1a55f42 to
45369db
Compare
| "dependencies": { | ||
| "commander": "^12.1.0", | ||
| "fast-glob": "^3.3.2", | ||
| "is-git-clean": "^1.1.0", |
There was a problem hiding this comment.
Can we try to use child_process exec from nodejs instead of external lib?
https://nodejs.org/api/child_process.html#child_processexeccommand-options-callback
There was a problem hiding this comment.
We can, but if this package already does its job well, why not use it?
There was a problem hiding this comment.
Shouldn't be that hard to achieve what you want with this proposal. It's probably a different story when something is complex or defeats the purpose of the library (for example commander).
If I had to choose between 10 different scripts vs 10 different packages for small or rather simple things I would pick the first option. It's better as you control this stuff and what it does.
If the given proposal with child_rocess can't be done easily we can revisit this topic
There was a problem hiding this comment.
@kjugi It's not something I would want to create and maintain. Having this package frees us from that work. I don't mind if you do it, but I won't be doing it.
There was a problem hiding this comment.
sure, I can visit this when I have some time. If I fail I want to use execa (or similar) to keep it open for similar ideas in the future
There was a problem hiding this comment.
Yep, you can use it, although it might be something for the future. I'd like to add this protection before launching it, if you agree. If not, we can leave it for the future.
bjohansebas
force-pushed
the
prevent-history
branch
from
45369db to
2ed1b42
Compare
As the title says, and other folders are added that wouldn't appear in a real project and would only create noise